|
Notes |
|
|
(0000872)
|
|
zs
|
|
2015-12-17 23:38
|
|
The bug is caused by process_module_long_interfaces in modules.m.
In int_impl_imports.m, the submodule int_impl_imports_2 is referenced twice:
it is used in the interface, and imported in the implementation.
grab_imported_modules process the import in the implementation first.
This reads the _2 module's .int file, and (since the import is NOT
in the interface) records that type bar is NOT available in the interface.
So far, so good. But when grab_imported_modules calls process_module_long_interfaces for the use in the interface,
it does not process the .int file again, since it has seen it before.
Not processing the .int file again is both right and wrong. Right because
it avoids double definitions, wrong because it leaves the incorrect permissions
for the type bar.
It is quote possible that earlier versions of Mercury got this right
only by accident. |
|
|
|
(0000873)
|
|
zs
|
|
2015-12-18 15:20
|
|
I am now sure that 14.01 got this right only by accident.
It also processes int_impl_imports_2.int just once,
for the import_module in the implementation. Its just that
due to a bug, the effect of that import was to make the
imported module available in ALL of int_impl_imports.m,
not just its interface. I fixed that bug on nov 11 in
commit 0821b301f25241bc706a325d4ae0cb9c18dd250b.
The fix of THAT bug exposed THIS bug.
I am now working on a fix. |
|
|
|
(0000875)
|
|
zs
|
|
2016-01-14 15:46
|
|
|
fix committed 2016 jan 11. |
|
|
|
(0000876)
|
|
wangp
|
|
2016-01-18 20:11
|
|
There is still a problem with the fix committed.
In tests/valid_seq:
% mmake int_impl_imports.depend
% mmake int_impl_imports.int
mmc --make-interface --grade asm_fast.gc --flags ../TESTS_FLAGS int_impl_imports
int_impl_imports.m:004: In module `int_impl_imports':
int_impl_imports.m:004: warning: module `int_impl_imports_2' is imported in
int_impl_imports.m:004: the interface, but it is not used in the interface.
int_impl_imports.m:006: In definition of type `int_impl_imports.foo'/0:
int_impl_imports.m:006: error: undefined type `int_impl_imports_2.bar'/0.
int_impl_imports.m:006: (The module `int_impl_imports_2' has not been
int_impl_imports.m:006: imported in the interface.)
`int_impl_imports.int' not written. |
|
|
|
(0001041)
|
|
zs
|
|
2019-08-04 09:39
|
|
|
Fix committed 2019 aug 3. |
|
int_impl_imports.m (175) 2015-12-17 18:00