2024-11-24 13:20 AEDT
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000518mercuryBugpublic2020-09-17 00:072020-09-17 07:18
Reporterkeri 
Assigned Tozs 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000518: Typo in extras/odbc.m
DescriptionWhen compiling extras/odbc.m a function symbol (stat) is being used instead of a variable (Statement) leading to the following warning:

odbc.m: In function 'odbc_module16':
odbc.m:1349:5: warning: the comparison will always evaluate as 'true for the address of 'stat' will never be NULL [-Waddress]
Additional InformationAttached is a diff to resolve this.
TagsNo tags attached.
Attached Files
  • patch file icon mercury-extras-odbc.patch (455 bytes) 2020-09-17 00:07 - 
    diff --git a/extras/odbc/odbc.m b/extras/odbc/odbc.m
index c8f5d1def..fd5271441 100644
--- a/extras/odbc/odbc.m
+++ b/extras/odbc/odbc.m
@@ -1346,7 +1346,7 @@ odbc_get_data_in_one_go(MODBC_Statement *statement, int column_id);
     [promise_pure, may_call_mercury],
 "
     Statement = Statement0;
-    MR_assert(stat != NULL);
+    MR_assert(Statement != NULL);
 
     if (Statement->num_rows == 0 ) {
         MR_DEBUG(printf(""Fetching rows...\\n""));
    patch file icon mercury-extras-odbc.patch (455 bytes) 2020-09-17 00:07 +

-Relationships
+Relationships

-Notes

~0001103

zs (developer)

2020-09-17 07:18

 The supplied patch has been committed. Thank you.
+Notes

-Issue History
Date Modified Username Field Change
2020-09-17 00:07 keri New Issue
2020-09-17 00:07 keri File Added: mercury-extras-odbc.patch
2020-09-17 07:18 zs Assigned To => zs
2020-09-17 07:18 zs Status new => resolved
2020-09-17 07:18 zs Resolution open => fixed
2020-09-17 07:18 zs Note Added: 0001103
+Issue History